refactor: replace cli-color with picocolors#1532
refactor: replace cli-color with picocolors#1532WikiRik merged 3 commits intosequelize:mainfrom JounQin:refactor/replace_cli-color
cli-color with picocolors#1532Conversation
|
The CI error should be unrelated: |
|
CI seems to be broken atm. It uses Even with that; in the new version of the CLI we're using ansis. Can we use that here as well? |
I'm not too familiar with the codebase yet, where should I change?
Didn't notice that, I'll try to replace |
|
The CI for PRs is here; https://github.com/sequelize/cli/blob/main/.github%2Fworkflows%2Fci.yml With the new version of the CLI, I meant the rewrite that we are doing over in the sequelize/sequelize repo for v7. This sequelize-cli library will be deprecated once that comes out. |
I already tried at And there is a new error: |
|
Hello @WikiRik, this PR is a duplicate.
|
@webdiscus I believe that's because Node 10 is not supported in your library? |
You are right:
In this case, Picocolors is the best choice. |
|
Hello everyone, Dropping |
|
Thanks everybody for the input. If/when the CI passes, I will approve this PR and see if I can get a new release out. |
|
🎉 This PR is included in version 6.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request check-list
Please make sure to review and check all of these items:
npm run testpass with this change (including linting)?Description of change
cli-color->es5-extdetected as a virusmedikoo/es5-ext#186
And
picocolorshas much lighter weight, no dependencies.